Skip to content

feat: commands の低優先掃除(update-codemaps 削除・checkpoint 縮小ほか)(#115、v0.65.0)#130

Merged
okash1n merged 1 commit into
mainfrom
issue/115-commands-cleanup
Jun 12, 2026
Merged

feat: commands の低優先掃除(update-codemaps 削除・checkpoint 縮小ほか)(#115、v0.65.0)#130
okash1n merged 1 commit into
mainfrom
issue/115-commands-cleanup

Conversation

@okash1n

@okash1n okash1n commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

概要

LLM 性能監査計画 #121 の P3-09(#115)。7 findings 対応。

変更内容

  • update-codemaps 削除: 静的コードマップ常設は旧モデルの探索能力不足への補償。30% 承認ゲート・TypeScript 固定指定も同時廃止。doc-updater agent の codemap 言及を一般化。doc-blocker の codemaps/ allowlist は既存ユーザーの生成物保護のため意図的に残置。既存配備分は retired 掃除で除去(snapshot のない pre-v0.31 インストールでは保護側に倒れて警告残置 — 既知の仕様)
  • checkpoint: native checkpoint/rewind(Esc Esc / /rewind)への委譲を明記し、セッション横断 git マイルストーン記録に縮小。記録していないテスト成績・カバレッジとの比較を要求していた verify の内部矛盾を解消
  • research: 「deeply examine 等の語句を使え」というマジックワード呪文を削除(精読の強制は維持)
  • update-kit: 「cat ではなく Read を使え」の文のみ削除(feature-recommendation スキップガード・conf 編集ガードレールは維持)
  • test-coverage: npm/pnpm・coverage-summary.json 固定をツール検出 + 例示に一般化(80% 閾値はキット規約として維持)
  • e2e + agents/e2e-runner: CI 例の actions@v4 / Node 22 ピンを除去し「生成時に最新を確認 / 既存 .github/workflows/ を基準に」へ(指示文との自己矛盾を構造的に解消)。テストをピン不在 + active LTS 文言の検証に反転し、commands/e2e.md もカバー
  • spec-kit-init: 「v0.10 が出たら再評価」の未来予告を現状記述(git extension opt-in / --no-git 廃止)に置換、4→5 steps 修正、Step 3 に specify extension add git 案内を追記

検証

  • unit 342/342 / scenarios 44 Pass + 1 Skip
  • 内部レビュー(code-reviewer agent): medium 1 件(commands/e2e.md のピン回帰テスト欠落)→ assert 追加済み。update-codemaps の参照漏れなし・update-kit の維持箇所無傷を確認済み

Closes #115

- update-codemaps 削除(静的マップは現行モデルの直接探索に劣後、コマンド数 21→20)
- checkpoint: native checkpoint/rewind 委譲を明記し git マイルストーン記録に縮小
- research: マジックワード呪文削除 / update-kit: ツール選択 babysitting 削除
- test-coverage: スタック検出 + 例示に一般化 / e2e + e2e-runner: CI バージョンピン除去
- spec-kit-init: v0.10 出荷済みの現状記述に更新、5 steps 不整合修正

Closes #115
Copilot AI review requested due to automatic review settings June 12, 2026 02:41
@okash1n okash1n merged commit b4ddbe6 into main Jun 12, 2026
12 checks passed
@okash1n okash1n deleted the issue/115-commands-cleanup branch June 12, 2026 02:43

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 90c90333aa

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread agents/e2e-runner.md
Comment on lines +34 to +35
- checkout
- setup-node (active LTS, cache npm)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Keep the CI example in valid workflow syntax

When the e2e-runner is asked to create a GitHub Actions workflow, this fenced yaml CI example is the pattern it will likely copy, but scalar entries like - checkout and - setup-node (...) are not valid workflow steps; GitHub documents step forms as jobs.<job_id>.steps[*].uses or jobs.<job_id>.steps[*].run (https://docs.github.com/en/actions/writing-workflows/workflow-syntax-for-github-actions). This can lead the agent to generate workflows that GitHub Actions rejects; keep the “verify latest versions” guidance, but preserve the uses:/with: structure or label this block as pseudocode.

Useful? React with 👍 / 👎.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR continues the #121 audit cleanup (P3-09 / #115) by removing legacy “old-model babysitting” from command/agent docs, deleting the /update-codemaps command, and tightening related documentation/tests for the new baselines.

Changes:

  • Removed /update-codemaps and updated documentation to reflect 21 → 20 commands.
  • Simplified /checkpoint, /research, /test-coverage, and /spec-kit-init to remove stale/over-prescriptive guidance.
  • Updated /e2e + e2e-runner to avoid hardcoded CI version pins and adjusted unit checks accordingly.

Reviewed changes

Copilot reviewed 14 out of 14 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
tests/unit/test-agent-definitions.sh Updates hygiene test expectations for e2e CI baseline guidance (avoid stale pins).
skills/eval-harness/SKILL.md Clarifies regression baseline wording (git SHA or checkpoint milestone).
README.md Updates slash command count references (21 → 20).
README.en.md Updates slash command count references (21 → 20).
commands/update-kit.md Removes tool-choice babysitting note while keeping guardrails.
commands/update-codemaps.md Deletes the /update-codemaps command content.
commands/test-coverage.md Generalizes coverage instructions beyond npm/pnpm and fixed report paths.
commands/spec-kit-init.md Fixes step count, updates v0.10+ behavior notes, and adds specify extension add git guidance.
commands/research.md Removes “magic words” requirement while keeping deep-read requirement.
commands/e2e.md Replaces hardcoded Actions/Node pins with “verify latest / use existing workflows” guidance.
commands/checkpoint.md Shrinks checkpoint to cross-session git milestone recording + diff/test status.
CHANGELOG.md Adds v0.65.0 entry documenting the above removals/changes.
agents/e2e-runner.md Removes pinned Actions/Node example and reframes CI guidance.
agents/doc-updater.md Generalizes doc-updater description/guardrails (codemap → generated docs/indexes).

Comment on lines +47 to +52
test_name="agents: e2e and security guidance avoid stale pinned baselines"
if ! grep -q 'actions/checkout@v' "$PROJECT_DIR/agents/e2e-runner.md" \
&& ! grep -q 'node-version:' "$PROJECT_DIR/agents/e2e-runner.md" \
&& ! grep -q 'actions/checkout@v' "$PROJECT_DIR/commands/e2e.md" \
&& ! grep -q 'node-version:' "$PROJECT_DIR/commands/e2e.md" \
&& grep -q 'active Node LTS' "$PROJECT_DIR/agents/e2e-runner.md" \
Comment thread commands/checkpoint.md
1. Run `/verify quick` to ensure current state is clean
2. Create a git stash or commit with checkpoint name
3. Log checkpoint to `.claude/checkpoints.log`:
2. Create a git commit or tag with the checkpoint name
Comment thread CHANGELOG.md
- **update-codemaps を削除(#115)**: 静的コードマップの常設維持は旧モデルの探索能力不足への補償で、現行モデルは必要時の直接探索の方が常に新鮮。恣意的な「30% 変更で承認」ゲートと「Use TypeScript/Node.js」指定も同時に廃止。agents/doc-updater の codemap 言及を一般化。doc-blocker の codemaps/ allowlist は既存ユーザーの生成物保護のため残置。既存配備分は update の retired 掃除で除去(コマンド数 21 → 20)

### Changed
- **checkpoint を git マイルストーン記録に縮小(#115)**: セッション内ロールバックはネイティブ checkpoint/rewind(Esc Esc / /rewind)に委譲することを明記し、本コマンドはセッション横断のマイルストーン記録専用に。記録していないデータ(過去のテスト成績・カバレッジ)との比較を要求していた verify の矛盾を解消(`git diff --stat` + 現在のテスト結果のみ報告)
Comment thread README.md
| **doc-updater** | ドキュメント更新 | README やドキュメントの更新 |

### 💬 スラッシュコマンド(21個
### 💬 スラッシュコマンド(20個
Comment thread agents/e2e-runner.md
Comment on lines 33 to 37
```yaml
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version: 22
cache: npm
- checkout
- setup-node (active LTS, cache npm)
- run: npm ci
- run: npx playwright install --with-deps
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[P3-09] commands の低優先掃除(checkpoint / research / update-codemaps / update-kit / test-coverage / e2e / spec-kit-init)

2 participants